Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

analyzer: Send back package and apps info for unknown OS if found. #103

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Apr 23, 2020

We should send back package and apps info if found even
in the case of an unknown OS. Example Dockerfile:

$ cat Dockerfile
FROM hello-world

ADD https://raw.githubusercontent.com/aquasecurity/trivy-ci-test/master/Cargo.lock .

Should say ErrUnknownOS but still scan the Cargo vulns.

Addresses: aquasecurity/trivy#470

Signed-off-by: Simarpreet Singh [email protected]

We should send back package and apps info if found even
in the case of an unknown OS. Example Dockerfile:

```
$ cat Dockerfile
FROM hello-world

ADD https://raw.githubusercontent.com/aquasecurity/trivy-ci-test/master/Cargo.lock .
```

Should say ErrUnknownOS but still scan the Cargo vulns.

Signed-off-by: Simarpreet Singh <[email protected]>
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to handle ErrNoPkgDetected as well, but it looks good to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants