Support checking for the last user as 'root' with a group specified, … #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case that fails today and will be fixed with this PR? |
|
I'd be happy to. Is there any documentation around writing and running the tests that I could review to get an understanding of the process? I looked over the architecture and contributing docs but didn't find the details. I can add the test to |
|
I found the steps in the Makefile and was able to verify the tests fail against master but pass here. :) |
simar7
force-pushed
the
fail_if_last_user_is_uid_0
branch
from
29a1904 to
f0e2752
Compare
simar7
approved these changes
May 25, 2023
added 2 commits
May 25, 2023 15:35
…and checking for a root user specified as UID 0, with or without a group GID specified Signed-off-by: Thomas Spear <[email protected]>
…group Signed-off-by: Thomas Spear <[email protected]>
simar7
force-pushed
the
fail_if_last_user_is_uid_0
branch
from
f0e2752 to
151b930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and checking for a root user specified as UID 0, with or without a group name or GID number specified