fix(rules): Update list of outdated ELB TLS policies #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS has added additional ELB security policies that support TLS v1.3. Some of them should be treated as outdated/unsafe, as they enable ciphers that are effectively deprecated. Note that the docs currently only show updates for NLBs, but in practice, ALBs also support these ELB security policies (guess the docs just aren't updated yet). https://docs.aws.amazon.com/elasticloadbalancing/latest/network/create-tls-listener.html
simar7
force-pushed
the
reed/update-outdated-tls-policies
branch
from
14c9cb0 to
cf40923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS has added additional ELB security policies that support TLS v1.3. Some of them should be treated as outdated/unsafe, as they enable ciphers that are effectively deprecated.
https://aws.amazon.com/about-aws/whats-new/2023/03/application-load-balancer-tls-1-3/
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/create-https-listener.html#describe-ssl-policies
Reasoning for each addition:
ELBSecurityPolicy-FS-2018-06-- supports TLS v1.0 and v1.1ELBSecurityPolicy-FS-1-1-2019-08-- supports TLS v1.1ELBSecurityPolicy-TLS13-1-0-2021-06-- supports TLS v1.0 and v1.1ELBSecurityPolicy-TLS13-1-1-2021-06-- supports TLS v1.1ELBSecurityPolicy-TLS13-1-2-Ext1-2021-06-- supports non elliptic curve cryptography cipher suitesELBSecurityPolicy-TLS13-1-2-Ext2-2021-06-- supports non elliptic curve cryptography cipher suites