added in redshift adapters #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorod3
previously approved these changes
Feb 21, 2023
| output = nil | ||
| } | ||
|
|
||
| var logenabled bool |
There was a problem hiding this comment.
can you change the naming convention to match the rest of the codebase (logEnabled)
| if err != nil { | ||
| return nil, err | ||
| } | ||
| apinodes = append(apinodes, output.ReservedNodes...) |
giorod3
previously approved these changes
Feb 27, 2023
|
@simar7 please also review and merge if you feel it looks good |
|
looks like some tests are failing, should be easy to fix. |
simar7
force-pushed
the
aws/redshift_policies
branch
from
e223755 to
0e73458
Compare
simar7
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.