Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Processors] rust token_v2_processor missing most NFT burn events #224

Open
alex4506 opened this issue Dec 28, 2023 · 1 comment
Open
Assignees
Labels
custom-processors Issues relating to the Custom Processors

Comments

@alex4506
Copy link

Description

If the NFT mint & burn acttions are not too close in time, the burn event will be missing

Repro

  1. Run the token_v2_processor
  2. Mint a NFT and wait for more than 1000 transaction versions
  3. Burn the NFT
  4. No burn event in token_activities_v2 table for this NFT

Analysis

The possible reason is the hashmap token_v2_metadata_helper is constructed by write resource, but the burn event like this has no such write resource, which breaks the process progress

@alex4506 alex4506 added the custom-processors Issues relating to the Custom Processors label Dec 28, 2023
@bowenyang007
Copy link
Collaborator

Good catch. Thanks for flagging! Looks like we need to reuse the same logic as token v2 ownership. https://github.com/aptos-labs/aptos-indexer-processors/blob/main/rust/processor/src/models/token_v2_models/v2_token_ownerships.rs#L222-L357. We'll need to fix this and backfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom-processors Issues relating to the Custom Processors
Projects
None yet
Development

No branches or pull requests

2 participants