Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to azure-sdk-for-go #1392

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Migrate to azure-sdk-for-go #1392

merged 2 commits into from
Nov 17, 2024

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Nov 11, 2024 •
edited
Loading

Fixes #1290

Description of the Change

  • migrate to new azure sdk

Checklist

  • FIXMEs, MD5 upload, ...

@neolynx neolynx self-assigned this Nov 11, 2024
@neolynx neolynx added WIP help wanted ! Please help getting this PR merged :-) labels Nov 11, 2024
@neolynx neolynx changed the title wip Migrate to azure-sdk-for-go Nov 11, 2024
@neolynx neolynx added fix tests Tests are failing needs review Ready for review & merge and removed fix tests Tests are failing labels Nov 11, 2024
neolynx
neolynx commented Nov 13, 2024
View reviewed changes
azure/public.go Outdated Show resolved Hide resolved
neolynx
neolynx commented Nov 13, 2024
View reviewed changes
azure/public.go Outdated Show resolved Hide resolved
@neolynx neolynx requested a review from a team November 13, 2024 21:02
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.12397% with 18 lines in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (d96ef0f) to head (d80b905).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
azure/public.go 74.19% 13 Missing and 3 partials ⚠️
azure/azure.go 97.36% 1 Missing ⚠️
azure/package_pool.go 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1392   +/-   ##
=======================================
  Coverage   74.82%   74.82%           
=======================================
  Files         157      157           
  Lines       18167    18176    +9     
=======================================
+ Hits        13593    13601    +8     
  Misses       3468     3468           
- Partials     1106     1107    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx force-pushed the fix/azure-sdk-migration branch from 39ea1c4 to 548594c Compare November 14, 2024 14:44
@neolynx neolynx removed the WIP label Nov 14, 2024
@neolynx neolynx force-pushed the fix/azure-sdk-migration branch from 548594c to 5dbeb67 Compare November 14, 2024 21:05
iofq
iofq requested changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@iofq iofq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update debian/control with the new azure go package

@neolynx neolynx force-pushed the fix/azure-sdk-migration branch from 5dbeb67 to 390a3a0 Compare November 17, 2024 13:03
@neolynx
Copy link
Member Author

neolynx commented Nov 17, 2024

Need to update debian/control with the new azure go package

I tried that, unfortunately the azure sdk package is lacking some modules in the latest version on debian, so this has to wait.
I am also synchronizing with the official debian packaging, and will ask if the missing go modules (mainly azure, swaggo, ..) could be provided for trixie.
The github pipeline is not building with debian dependencies, so the debian/control does not matter there...

@iofq
Copy link
Contributor

iofq commented Nov 17, 2024

Need to update debian/control with the new azure go package

I tried that, unfortunately the azure sdk package is lacking some modules in the latest version on debian, so this has to wait. I am also synchronizing with the official debian packaging, and will ask if the missing go modules (mainly azure, swaggo, ..) could be provided for trixie. The github pipeline is not building with debian dependencies, so the debian/control does not matter there...

gotcha so this must just be for building from source (deb-src)?

@neolynx
Copy link
Member Author

neolynx commented Nov 17, 2024

Need to update debian/control with the new azure go package

I tried that, unfortunately the azure sdk package is lacking some modules in the latest version on debian, so this has to wait. I am also synchronizing with the official debian packaging, and will ask if the missing go modules (mainly azure, swaggo, ..) could be provided for trixie. The github pipeline is not building with debian dependencies, so the debian/control does not matter there...

gotcha so this must just be for building from source (deb-src)?

yes, this is just for debian native build, with debian only dependencies, like molior aptly and debian official builds...

@neolynx neolynx closed this Nov 17, 2024
@neolynx neolynx reopened this Nov 17, 2024
@neolynx neolynx force-pushed the fix/azure-sdk-migration branch from 390a3a0 to d80b905 Compare November 17, 2024 16:44
@neolynx neolynx merged commit 763b810 into master Nov 17, 2024
46 checks passed
@neolynx neolynx deleted the fix/azure-sdk-migration branch November 17, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iofq iofq iofq approved these changes

Assignees

@neolynx neolynx

Labels
help wanted ! Please help getting this PR merged :-) needs review Ready for review & merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Storage Blob SDK for Go DEPRECATED
2 participants
@neolynx @iofq