-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add change log file. #354
Add change log file. #354
Conversation
Since you don't use |
Hey @skywinder, That tool looks very nice, I like to automate boring tasks like that. But I notice strange bug in generated changelog: |
@alexgarbarev Since #342 closed 19 days ago (2nd of may) and tag 3.1.6 is placed 1st of may - generator assumes, that it was closed after release. That is a known case (look at github-changelog-generator/github-changelog-generator#22 for more details).
That is the easies an more convenient way, that I fugired out. If you have other ideas, how is better to handle such situation - let me know! So, just set milestone for this issue |
Let's merge in and fix up issues with the change log. While we generally push value adding features as a micro-version as soon as they're available, users have been asking for a more formal tracking. Given that Typhoon is a self funded open source project it adds some overheads, so we really appreciate being able to automate. |
@skywinder Ah.. Got it! Thanks for explanation! I didn't notice that before! |
@skywinder Just checked again.. Can't understand what wrong here: Tag 3.1.6 Commit "Fixed bug #342" So.. Looks like tag cannot be set earlier than this bugfix commit, because 3.1.6 tag points to that commit |
Hey, Just now I pushed new release @skywinder, Can you help me to understand what I'm doing wrong? |
@alexgarbarev ok, let me check it tomorrow! I will handle it! 😉 |
The 'pod' badge in the readme links to the old (poorly maintained) changelog. Once ready we can link to the new one. |
@alexgarbarev with #352 & 3.1.8 - it's definitely that case, that I describe above. Tag 3.1.8 And issue closed (according github popup message) at 23:45 (GMT +6) |
Makes sense. Sometimes I have had to push a new release while some tickets are still marked as 'Ready for Review' . . . we'll have to avoid this in future. |
@alexgarbarev Gotcha! You create reference to the issue with commit, But it don't close commit (because of formatting of commit message - at 2nd of May 0:50 GMT +3 And tag date is 1st of May 23:51 GMT +3 That's why it's not in this section. |
Ah.. Right, thanks for explanation. I didn't know that |
@alexgarbarev Ok, but there is another bug (or feature ❓ ). As you mention - there is no #352 at all! Even if it closed later - it should appear in If you have ideas, how better to handle such cases - I will be glad discuss it! |
Add missed issues in #354
Hi, as I can see, you are carefully fill tags and labels for issues in your repo.
For such cases I create a github_changelog_generator, that generate change log file based on tags, issues and merged pull requests from Issue Tracker.
This PR add change log file to your repo (generated by this script).
You can check, how it is look like here: Change Log
Some essential features, that has this script:
question
duplicate
invalid
wontfix
)merged
pull-requests)bug
in issue)enhancement
in issue)w/o any labels
)You can easily update this file in future by simply run script:
github_changelog_generator appsquickly/Typhoon
in your repo folder and it make your Change Log file up-to-date again!Hope you find this commit as useful. 😉