Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of BOOL where TyphoonComponentInitializerIsClassMethod expected, fix warnings #35

Merged
merged 9 commits into from
Jul 24, 2013
Merged

Fix usage of BOOL where TyphoonComponentInitializerIsClassMethod expected, fix warnings #35

merged 9 commits into from
Jul 24, 2013

Conversation

rhgills
Copy link
Contributor

@rhgills rhgills commented Jul 23, 2013

No description provided.

@rhgills
Copy link
Contributor Author

rhgills commented Jul 23, 2013

Seems like it'd be a good idea to also rename - (id)initWithSelector:(SEL)initializer isClassMethod:(TyphoonComponentInitializerIsClassMethod)isClassMethod on TyphoonInitializer to communicate that the isClassMethod: param is no longer a BOOL. But, I'm still a bit hesitant to change the API, despite the fact that I don't recall it ever being encouraged to directly instantiate TyphoonInitializer.

jasperblues added a commit that referenced this pull request Jul 24, 2013
@jasperblues
Merge pull request #35 from rhgills/is-class-method
d68a81b 
Fix usage of BOOL where TyphoonComponentInitializerIsClassMethod expected, fix warnings
@jasperblues jasperblues merged commit d68a81b into appsquickly:master Jul 24, 2013
@jasperblues
Copy link
Member

Thanks Robert!

Yes, I agree on the method rename.

@VincentWenShuo VincentWenShuo mentioned this pull request May 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhgills @jasperblues