Block-style Initializer and properties: Allow injection of primitive

[eriksundin]

Issue #100

[jasperblues]

We've got four failing tests on the main branch here. . . makes it difficult to merge in other contributions.

@rhgills - huge appreciation for identifying these issues. However, please follow the policy we agreed.

[rhgills]

@jasperblues My apologies. Everything was passing on my end, but I see we have three failing tests on master right now.

One in (the re-added) TyphoonTestUtilsTests and two in TyphoonComponentDefinition+InstanceBuilderTests (which may be an issue with different sizes of NSUIntegerMax between 32 and 64 bit). What tests do you see as failing?

I haven't changed either of these recently, did you mean to @eriksundin?

[jasperblues]

TyphoonTestUtiils tests was failing just in the assertion:

"Condition didn't happen before 2.0" now "Condition didn't happen before 0.1" . . fixed. . not sure what is happening in the other class.

[eriksundin]

@rhgills I've added new tests in TyphoonComponentDefinition+InstanceBuilderTests, was not failing for me ... so yes could be related to environment. Let me check.

[rhgills]

I commented out the two tests (related to NSUIntegerMax) that were failing for me in d900878.

[eriksundin]

Thanks @rhgills

[eriksundin]

I was/am getting a test failure on TyphoonBlockComponentFactory_CollectionTests (test_dealloc_cleans_up_method_advising) ... You guys not getting that one?

[rhgills]

I wasn't before, but I began to have some failures today when I was making some changes to the AssemblyAdviser (that I haven't pushed yet). That test passes for me on the current HEAD.

I believe the issue with that test in general is that we can't control when the assembly will be deallocated by ARC. It's interesting that you're getting a failure there and I'm not, I wouldn't think ARC would appear nondeterministic in that way...

I've scrapped that entire test locally and replaced it with a unit test on the AssemblyAdviser. I'll go ahead and quickly remove that test from the server now.

[rhgills]

Done.

[rhgills]

@jasperblues @eriksundin

Can you confirm master is back to passing?

[eriksundin]

@rhgills Yes, passing for me. Working on fixing the tests you commented out.

[eriksundin]

@rhgills I just pushed 02a7bcc with fixes. Can you check/confirm the tests pass on your machine?

[rhgills]

All passing here!

[eriksundin]

👍