-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advantages of TyphoonFactoryProvider over runtime args? #225
Comments
I think that runtime args + new category TyphoonDefinition+Option can replace FactoryProvider for most cases. |
The only benefit, and why I build the system originally, is that the user code is not “tainted” by Typhoon, so stripping Typhoon away should be easier. Obviously this is my requirement, not something everyone “lives by”. I really don’t know how many people uses it besides me (and my old team), and I actually not using actively anymore, so I will not fight if you want to remove it. |
With regards to tainting/non-invasive the following is possible:
Quite a few folks have reported using this feature, but now that we've got the runtime args, I figured they might be happy enough with that feature. . . if we can support just one, then we might see a few more weekends. |
@jasperblues |
OK. I mashed the docs from the original TyphoonFactoryProvider onto the runtime args feature. For simplicity I think it makes sense to deprecate this in favor of the new runtime-args feature. As @jervine10 points out we can still decouple Typhoon, by creating a protocol and having the assembly conform to it. |
Hi @jasperblues ! I'm looking for a migration guide between version because we were in 1.8.2 and want to updated (to 3.4.5).
I am lost :( |
Was it not clear after reading about: https://github.com/appsquickly/Typhoon/wiki/Types-of-Injections#injection-with-run-time-arguments If not could you provide some more code? The code for your factory provider, etc? |
What are the advantages of TyphoonFactoryProvider over runtime args? (if any).
We were able to get runtime args in sooner than expected. Would it make sense to deprecate TyphoonFactoryProvider in favor of runtime args?
The text was updated successfully, but these errors were encountered: