Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block-style Initializer and properties: Allow injection of primitive #100

Closed
jasperblues opened this issue Nov 11, 2013 · 7 comments
Closed

Comments

@jasperblues
Copy link
Member

No description provided.

@eriksundin
Copy link
Contributor

Are you thinking about something inline with this?
And adding support for the full list defined in TyphoonTypeDescriptor.

[initializer injectWithInt:10];

...

[definition injectProperty:@selector(prop) withLong:1.0];
[definition injectProperty:@selector(prop) withBoolean:YES];

...

@jasperblues
Copy link
Member Author

Yup, in the block-style the text-conversion looks weird as it is now. . . If I want to inject an enum I have to jump through some hoops.

@eriksundin
Copy link
Contributor

Agree. Ran into the enum scenario just a few days ago.

I can take a pass on this issue, have some time in the coming days to look at it.

@ghost ghost assigned eriksundin Dec 12, 2013
@jasperblues
Copy link
Member Author

Great!

@eriksundin
Copy link
Contributor

I'm not able to run the tests from command line at the moment .. missing the 6.1 environment used.
So I've not done the 'ant no-fail-tests build-publish' at the moment, don't want to publish empty test reports.

@jasperblues
Copy link
Member Author

I was using 6.1 so that we can produce test coverage reports. 7.0 had a bug. . . However the class VATestObserver now fixes this, and flushes the coverage data before closing.

Therefore we can now shift to 7.0 is the main test platform.

In any case the build server should be back today. .

@eriksundin
Copy link
Contributor

Thanks for the background info on that.

Good to hear the build server is on the road to recovery!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants