From 29f9fa7316dd56322a6f831f1e050cf6003ee067 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Csneha122=E2=80=9D?= <“sneha@appsmith.com”> Date: Wed, 8 May 2024 15:43:05 +0530 Subject: [PATCH 1/6] fix: turned on learnability flags on by default --- app/client/src/ce/entities/FeatureFlag.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/client/src/ce/entities/FeatureFlag.ts b/app/client/src/ce/entities/FeatureFlag.ts index c126cac1b49e..5ab5733e0644 100644 --- a/app/client/src/ce/entities/FeatureFlag.ts +++ b/app/client/src/ce/entities/FeatureFlag.ts @@ -88,8 +88,8 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = { rollout_remove_feature_walkthrough_enabled: false, rollout_js_enabled_one_click_binding_enabled: false, rollout_side_by_side_enabled: false, - ab_learnability_ease_of_initial_use_enabled: false, - ab_learnability_discoverability_collapse_all_except_data_enabled: false, + ab_learnability_ease_of_initial_use_enabled: true, + ab_learnability_discoverability_collapse_all_except_data_enabled: true, release_layout_conversion_enabled: false, }; From 06cc1c5e6d920c075b9c627e025d343466b9b688 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Csneha122=E2=80=9D?= <“sneha@appsmith.com”> Date: Wed, 8 May 2024 20:20:52 +0530 Subject: [PATCH 2/6] fix: failing cypress tests issue fixed --- app/client/cypress/support/Objects/FeatureFlags.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/client/cypress/support/Objects/FeatureFlags.ts b/app/client/cypress/support/Objects/FeatureFlags.ts index bd6c9b080a76..ac5f4a0da90d 100644 --- a/app/client/cypress/support/Objects/FeatureFlags.ts +++ b/app/client/cypress/support/Objects/FeatureFlags.ts @@ -4,6 +4,10 @@ import produce from "immer"; const defaultFlags = { release_side_by_side_ide_enabled: true, + ab_learnability_discoverability_collapse_all_except_data_enabled: false, // remove this flag from here when it's removed from code + ab_learnability_ease_of_initial_use_enabled: false, // remove this flag from here when it's removed from code + rollout_remove_feature_walkthrough_enabled: false, // remove this flag from here when it's removed from code + rollout_js_enabled_one_click_binding_enabled: false, // remove this flag from here when it's removed from code }; export const featureFlagIntercept = ( From 36114b693fd2ff384ce392829bfcb9c9d2101c27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Csneha122=E2=80=9D?= <“sneha@appsmith.com”> Date: Wed, 8 May 2024 20:34:46 +0530 Subject: [PATCH 3/6] fix: flags on by default --- app/client/src/ce/entities/FeatureFlag.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/client/src/ce/entities/FeatureFlag.ts b/app/client/src/ce/entities/FeatureFlag.ts index 5ab5733e0644..2c9333f19df0 100644 --- a/app/client/src/ce/entities/FeatureFlag.ts +++ b/app/client/src/ce/entities/FeatureFlag.ts @@ -85,8 +85,8 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = { release_global_add_pane_enabled: false, ab_appsmith_ai_query: false, release_actions_redesign_enabled: false, - rollout_remove_feature_walkthrough_enabled: false, - rollout_js_enabled_one_click_binding_enabled: false, + rollout_remove_feature_walkthrough_enabled: true, + rollout_js_enabled_one_click_binding_enabled: true, rollout_side_by_side_enabled: false, ab_learnability_ease_of_initial_use_enabled: true, ab_learnability_discoverability_collapse_all_except_data_enabled: true, From 95d091616610ba0c93e396305894711ae29237c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Csneha122=E2=80=9D?= <“sneha@appsmith.com”> Date: Thu, 9 May 2024 12:23:30 +0530 Subject: [PATCH 4/6] fix: failing cypress test cases fixed --- app/client/cypress/support/Objects/FeatureFlags.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/client/cypress/support/Objects/FeatureFlags.ts b/app/client/cypress/support/Objects/FeatureFlags.ts index ac5f4a0da90d..c7f4b58bdf65 100644 --- a/app/client/cypress/support/Objects/FeatureFlags.ts +++ b/app/client/cypress/support/Objects/FeatureFlags.ts @@ -5,9 +5,7 @@ import produce from "immer"; const defaultFlags = { release_side_by_side_ide_enabled: true, ab_learnability_discoverability_collapse_all_except_data_enabled: false, // remove this flag from here when it's removed from code - ab_learnability_ease_of_initial_use_enabled: false, // remove this flag from here when it's removed from code rollout_remove_feature_walkthrough_enabled: false, // remove this flag from here when it's removed from code - rollout_js_enabled_one_click_binding_enabled: false, // remove this flag from here when it's removed from code }; export const featureFlagIntercept = ( From b95ebe1f301edd2c2a5ba83aa52aee873600af64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Csneha122=E2=80=9D?= <“sneha@appsmith.com”> Date: Fri, 10 May 2024 15:17:34 +0530 Subject: [PATCH 5/6] fix: propertyControl updates --- .../ClientSide/OneClickBinding/PropertyControl_spec.ts | 6 ------ app/client/cypress/limited-tests.txt | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts index 70fe9f1d1e9d..2ecdeb7a2aca 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts @@ -82,12 +82,6 @@ describe( agHelper.GetNClick(oneClickBindingLocator.datasourceQuerySelector(), 0); - agHelper.AssertElementExist( - oneClickBindingLocator.dropdownOptionSelector("Query1"), - ); - - propPane.ToggleJSMode("Table data"); - propPane.ValidatePropertyFieldValue("Table data", "{{Query1.data}}"); propPane.AssertJSToggleState("Table data", "enabled"); diff --git a/app/client/cypress/limited-tests.txt b/app/client/cypress/limited-tests.txt index 31c0c0253fef..70d6b5a36d48 100644 --- a/app/client/cypress/limited-tests.txt +++ b/app/client/cypress/limited-tests.txt @@ -1,5 +1,5 @@ # To run only limited tests - give the spec names in below format: -cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js +cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts # For running all specs - uncomment below: #cypress/e2e/**/**/* From e430215c66e067f36b8af04e04e344d6fe15e09e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Csneha122=E2=80=9D?= <“sneha@appsmith.com”> Date: Mon, 13 May 2024 13:59:35 +0530 Subject: [PATCH 6/6] fix: reverted tag all --- app/client/cypress/limited-tests.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/client/cypress/limited-tests.txt b/app/client/cypress/limited-tests.txt index 70d6b5a36d48..31c0c0253fef 100644 --- a/app/client/cypress/limited-tests.txt +++ b/app/client/cypress/limited-tests.txt @@ -1,5 +1,5 @@ # To run only limited tests - give the spec names in below format: -cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts +cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js # For running all specs - uncomment below: #cypress/e2e/**/**/*