From 4c80891b1c2edf1a22be5f0080778b2afe23736f Mon Sep 17 00:00:00 2001
From: Alex Golovanov <alex@appsmith.com>
Date: Tue, 4 Feb 2025 13:57:15 +0300
Subject: [PATCH] Restore data-testid attributes & update unit tests.

---
 .../ads/src/DismissibleTab/DismissibleTabBar.tsx            | 1 +
 app/client/src/pages/Editor/IDE/EditorTabs/AddTab.tsx       | 1 +
 app/client/src/pages/Editor/IDE/EditorTabs/EditableTab.tsx  | 2 ++
 .../src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx     | 6 ++++--
 app/client/src/pages/Editor/IDE/EditorTabs/index.tsx        | 1 +
 5 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/app/client/packages/design-system/ads/src/DismissibleTab/DismissibleTabBar.tsx b/app/client/packages/design-system/ads/src/DismissibleTab/DismissibleTabBar.tsx
index 2eeba0cb6f08..88ee35fe4a54 100644
--- a/app/client/packages/design-system/ads/src/DismissibleTab/DismissibleTabBar.tsx
+++ b/app/client/packages/design-system/ads/src/DismissibleTab/DismissibleTabBar.tsx
@@ -107,6 +107,7 @@ export const DismissibleTabBar = ({
             <Spinner size="md" />
           ) : (
             <Styled.PlusButton
+              data-testid="t--ide-tabs-add-button"
               isDisabled={disableAdd}
               isIconButton
               kind="tertiary"
diff --git a/app/client/src/pages/Editor/IDE/EditorTabs/AddTab.tsx b/app/client/src/pages/Editor/IDE/EditorTabs/AddTab.tsx
index 216af306e13a..87a586864402 100644
--- a/app/client/src/pages/Editor/IDE/EditorTabs/AddTab.tsx
+++ b/app/client/src/pages/Editor/IDE/EditorTabs/AddTab.tsx
@@ -32,6 +32,7 @@ const AddTab = ({
 
   return (
     <DismissibleTab
+      dataTestId="t--ide-tab-new_query"
       isActive={segmentMode === EditorEntityTabState.Add && !isListActive}
       onClick={newTabClickCallback}
       onClose={onCloseClick}
diff --git a/app/client/src/pages/Editor/IDE/EditorTabs/EditableTab.tsx b/app/client/src/pages/Editor/IDE/EditorTabs/EditableTab.tsx
index bf8416d87866..420f97086d36 100644
--- a/app/client/src/pages/Editor/IDE/EditorTabs/EditableTab.tsx
+++ b/app/client/src/pages/Editor/IDE/EditorTabs/EditableTab.tsx
@@ -9,6 +9,7 @@ import { FEATURE_FLAG } from "ee/entities/FeatureFlag";
 import { getIsSavingEntityName } from "ee/selectors/entitiesSelector";
 
 import { useFeatureFlag } from "utils/hooks/useFeatureFlag";
+import { sanitizeString } from "utils/URLUtils";
 
 import {
   getEditableTabPermissions,
@@ -63,6 +64,7 @@ export function EditableTab(props: EditableTabProps) {
   return (
     <EditableDismissibleTab
       canEdit={isChangePermitted}
+      dataTestId={`t--ide-tab-${sanitizeString(title)}`}
       icon={icon}
       isActive={isActive}
       isEditable={isChangePermitted}
diff --git a/app/client/src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx b/app/client/src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx
index df7623c7948b..495c8f3de248 100644
--- a/app/client/src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx
+++ b/app/client/src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx
@@ -44,7 +44,8 @@ describe("EditorTabs render checks", () => {
     // check tabs is empty
     const tabsContainer = getByTestId("t--tabs-container");
 
-    expect(tabsContainer.firstChild).toBeNull();
+    // tabs container contains 2 sentinel divs to check for intersections, so in empty state it should have 2 children
+    expect(tabsContainer.childElementCount).toBe(2);
 
     //check add button is not present
     expect(queryByTestId("t--ide-tabs-add-button")).toBeNull();
@@ -69,7 +70,8 @@ describe("EditorTabs render checks", () => {
     // check tabs is empty
     const tabsContainer = getByTestId("t--tabs-container");
 
-    expect(tabsContainer.firstChild).toBeNull();
+    // tabs container contains 2 sentinel divs to check for intersections, so in empty state it should have 2 children
+    expect(tabsContainer.childElementCount).toBe(2);
 
     //check add button is not present
     expect(queryByTestId("t--ide-tabs-add-button")).toBeNull();
diff --git a/app/client/src/pages/Editor/IDE/EditorTabs/index.tsx b/app/client/src/pages/Editor/IDE/EditorTabs/index.tsx
index fdf4e21c55f9..b3c78c5b5c9d 100644
--- a/app/client/src/pages/Editor/IDE/EditorTabs/index.tsx
+++ b/app/client/src/pages/Editor/IDE/EditorTabs/index.tsx
@@ -93,6 +93,7 @@ const EditorTabs = () => {
       <EntityTabsHeader>
         {showEntityListButton && (
           <EntityListButton
+            data-testid="t--list-toggle"
             isSelected={isListViewActive}
             onClick={handleHamburgerClick}
           />