Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web export needs implemented #23

Closed
Ughuuu opened this issue Oct 30, 2023 · 9 comments
Closed

Web export needs implemented #23

Ughuuu opened this issue Oct 30, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@Ughuuu
Copy link
Contributor

Ughuuu commented Oct 30, 2023

Maybe related to this?

godotengine/godot#82865

Try out when that is fixed.

@Ughuuu Ughuuu added the bug Something isn't working label Oct 30, 2023
@souvikinator
Copy link

Hi! Any update on this?

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Mar 26, 2024

From what i see the linked issue is still open. So probably still wont work

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Mar 30, 2024

Actually the simd-stable also doesnt work with web. Disabled that in this PR #46 to see if it works. Will update if it works. Am investigating still tho.

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Apr 3, 2024

Small update on this. Make it start at all. Before it didn't want to load the dll, now it loads it, but at the step function it throws in the browser:

Aborted(Assertion failed: bad function pointer type - dynCall function not found for sig 'vijiiiiiiiiiiii')
	$world_step
	$_ZN13RapierSpace2D4stepEf

I am building locally with emscripten 3.1.56, but will try with other version to see if it works with any. Godot GDExtension uses 3.1.45, with that it doesn't load at all.

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Apr 4, 2024

By removing the call to step from rapier code, it works. So the problem is the world_step function and what it does most likely.
I think first I would need to keep on removing stuff from step and see what causes it (my guess is it's the callbacks or their signature).

@Ughuuu Ughuuu added enhancement New feature or request and removed bug Something isn't working labels Apr 12, 2024
@Ughuuu
Copy link
Contributor Author

Ughuuu commented Apr 25, 2024

Ok, on this, I looked at what godot-rust is doing, and they have web exports working. So I think migrating this addon to be a godot-rust gdext would give us web exports.

Issue link where they describe how they added support for building web exports:
godot-rust/gdext#438

@Ughuuu Ughuuu changed the title Web export doesn't work Web export doesn't work - Needs rewrite to gdext Apr 25, 2024
@Ughuuu Ughuuu changed the title Web export doesn't work - Needs rewrite to gdext Web export needs implemented Jun 19, 2024
@Ughuuu
Copy link
Contributor Author

Ughuuu commented Jun 19, 2024

Follow this for info godot-rust/gdext#438

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Jun 24, 2024

Ok, now that I rewrote it to rust, I'll see if it will work. Also 4.3 did some changes to help with this, will try to see if anything changed on this issue.

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Jun 28, 2024

Removing it from issues as it is in readme as limitation. Better to not track it in issues also.

@Ughuuu Ughuuu closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants