Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for custom plugin #356

Merged
merged 23 commits into from
May 18, 2018
Merged

Add documentation for custom plugin #356

merged 23 commits into from
May 18, 2018

Conversation

mirshahriar
Copy link
Contributor

No description provided.

@mirshahriar mirshahriar requested a review from tamalsaha April 25, 2018 05:44
@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   31.64%   31.64%           
=======================================
  Files          14       14           
  Lines         986      986           
=======================================
  Hits          312      312           
  Misses        623      623           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f28cab...4ea162d. Read the comment docs.

alertKinds:
- ClusterAlert
arguments:
vars:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain the spec.vars with more detailed examples.

@@ -0,0 +1,149 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this into the webhook doc.

name: cert-demo-0
namespace: demo
spec:
check: cert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a Secret with a TLS cert and then use that name to check for expiration. Use onessl to issue the cert.
https://github.com/kubepack/onessl/releases/tag/0.3.0

aerokite and others added 8 commits May 17, 2018 12:36
# Conflicts:
#	docs/examples/plugins/check-command/event.conf
#	docs/examples/plugins/check-command/json-path.conf
#	docs/examples/plugins/check-command/node-exists.conf
#	docs/examples/plugins/check-command/node-status.conf
#	docs/examples/plugins/check-command/node-volume.conf
#	docs/examples/plugins/check-command/pod-exec.conf
#	docs/examples/plugins/check-command/pod-exists.conf
@tamalsaha
Copy link
Contributor

@aerokite , the plugin doc is missing the most important part. How we convert the vars to json format. There is no mention of that.

@tamalsaha tamalsaha merged commit ae66d8d into master May 18, 2018
@tamalsaha tamalsaha deleted the add-doc branch May 18, 2018 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants