Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_node_status to support other NodeCondition #309

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

mirshahriar
Copy link
Contributor

Issue: #198

@mirshahriar mirshahriar self-assigned this Mar 16, 2018
@mirshahriar mirshahriar requested a review from tamalsaha March 16, 2018 06:56
@codecov-io
Copy link

codecov-io commented Mar 16, 2018

Codecov Report

Merging #309 into master will increase coverage by 4.22%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage    26.8%   31.03%   +4.22%     
==========================================
  Files           7        8       +1     
  Lines         373      435      +62     
==========================================
+ Hits          100      135      +35     
- Misses        262      287      +25     
- Partials       11       13       +2
Impacted Files Coverage Δ
plugins/check_node_status/lib.go 56.45% <61.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b76502...8222921. Read the comment docs.

@tamalsaha tamalsaha merged commit c701f38 into master Mar 16, 2018
@tamalsaha tamalsaha deleted the node-status branch March 16, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants