Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors building with Catch v2.11.0 but works with v2.13.8 #17

Open
reedhedges opened this issue Jan 28, 2022 · 2 comments
Open

Errors building with Catch v2.11.0 but works with v2.13.8 #17

reedhedges opened this issue Jan 28, 2022 · 2 comments

Comments

@reedhedges
Copy link

reedhedges commented Jan 28, 2022

I updated catch2 to 2.13.8 (latest version of v2) and the build works now.

(Just downloaded it to lib/catch2/include/catch2 as catch.v2.13.8.hpp and edited lib/catch2/include/catch2/catch3.hpp to include the new version)

Before upgrading catch2 I received 2 compile errors:

/home/reed/examples/ApprovalTestsCpp_StarterProject/lib/catch2/include/catch2/catch.v2.11.0.hpp:10717:58: error: call to non-‘constexpr’ function ‘long int sysconf(int)’
10717 |     static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;

and

/home/reed/examples/ApprovalTestsCpp_StarterProject/lib/catch2/include/catch2/catch.v2.11.0.hpp:10776:45: error: size of array ‘altStackMem’ is not an integral constant-expression
10776 |     char FatalConditionHandler::altStackMem[sigStackSize] = {};

on Linux with g++ 11.2.0.

@claremacrae
Copy link
Contributor

Thanks for the report. Glad to hear that you got it working.

@reedhedges
Copy link
Author

reedhedges commented Feb 1, 2022

Should it be updated in the repository? Let me know if you'd like a PR to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants