Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor API change proposal for overloaded verifyAll functions #233

Open
ragunathjawahar opened this issue Jan 13, 2022 · 0 comments
Open

Comments

@ragunathjawahar
Copy link
Contributor

The following overloaded function has a parameter named f1. It is unclear what this function does and requires a bit of guess work. Can we rename it to formatter?

Now

public static <T> void verifyAll(String header, Iterable<T> array, Function1<T, String> f1)

After

public static <T> void verifyAll(String header, Iterable<T> array, Function1<T, String> formatter)

This change would still maintain binary compatibility backwards. I can raise a PR if necessary. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant