Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parameter names in combination approvals #194

Open
ragunathjawahar opened this issue Oct 9, 2021 · 0 comments
Open

Allow parameter names in combination approvals #194

ragunathjawahar opened this issue Oct 9, 2021 · 0 comments

Comments

@ragunathjawahar
Copy link
Contributor

Here's a sample approved file generated via combination approvals. The input parameters are enclosed within square brackets and are unnamed. This makes it hard when dealing with more parameters. A provision to prefix these parameters with their names could help readability and reduce cognitive load.

Current

[-1, -1] => [Aged Brie, -2, 1] 
[-1, 0] => [Aged Brie, -2, 2] 
[-1, 1] => [Aged Brie, -2, 3] 
[-1, 49] => [Aged Brie, -2, 50] 
…

Proposed

[sellIn: -1, quality: -1] => [Aged Brie, -2, 1] 
[sellIn: -1, quality: 0] => [Aged Brie, -2, 2] 
[sellIn: -1, quality: 1] => [Aged Brie, -2, 3] 
[sellIn: -1, quality: 49] => [Aged Brie, -2, 50] 
…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant