-
Notifications
You must be signed in to change notification settings - Fork 131
Suggestion: Backport to Json.NET 11.x.x, 10.x.x, 9.x.x, and 8.x.x #16
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Change of mind, will not some versions. Note added to description:
|
Hi, your marked the comment from tsweeper as off-topic , but would porting to newtonsoft json 10.0.x solve the issue ? (We're encountering this same issue on Google but also Jira, both dll can't load the forked json dll) |
Yes it would! Actually it's just the version number that's the problem. I've not found the time to start backporting. Hopefully soon. |
@jilleJr Please keep us informed, as SinglaR is using Newtonsoft Assembly 'Assets/Plugins/Microsoft.AspNetCore.SignalR.Common.dll' will not be loaded due to errors: We could offer you beer to boost your deliveries ;) |
@xabio Ooo nice that you're using SignalR :o I must though counter with my list of excuses:
That being said, I did actually kind of expect Unity's fork of my repo to add backporting, but I must've misunderstood them. Seems like they never will add backports. I'll take a closer look at this, see if it's really that difficult and tedious. Side note: I currently don't take beer as a payment ;) I am accepting donations for coffee, though I'm currently getting more money than I'm spending on coffee (OpenCollective ensures I only spend money on stuff I'm accepting donations for). Odd problem to have. |
@jilleJr and is there some way to tell Unity to take that Newtonsoft you have created, as it was the 11.0.0 version ? |
@xabio sorry to say that binding redirections are not supported in Unity. Which also means you can only use 1 version of Newtonsoft.Json at a time. |
@xabio I tried and backporting to 11.0.2 was not that difficult actually. I think mostly because 11.0.2 and 12.0.3 are differenciating in more or less bug fixes only. I'm honestly quite scared of attempting this for 10.0.3, but as Json .NET 10.x has been so frequently requested, I will at least make an honest attempt on it. I didn't think about the Newtonsoft.Json-for-Unity 11.0.202 (based on Newtonsoft.Json 11.0.2) has just been released and is available via the Cloudsmith and OpenUPM registries already |
Happy news! Now the package has both a Json .NET v11.0.2 and a v10.0.3 backports! @tsweeper It is 473 days later, so I assume you may have moved on to a different project like 3 consecutive times by now, but as they say: Better late than never 😅 You should now be able to use google.apis.sheets.v4 with this package :) It's much less relevant nowadays as since their Google.Apis.Core v1.44.0 they switched to using Newtonsoft.Json 12.0.x. I'm pulling the breaks here on the backporting. I'm not going to backport any further unless someone really needs it. It was since Json .NET 10.0.x that they started using the new SDK styled csproj format, and the older format is such an extreme headache to work with. If anyone needs Json.NET v9.0.x or lower, then open a new issueTo be extra clear: It's not planned, but I will consider it if anyone needs it. I want to get to work on other stuff for this repo. This issue has been dragging my mind for too long. |
Description
This project is lacking for the users who do not want to update their projects to target a Json..NET 12.0.1. Suggesting to downgrade all the way down to 8.0.3. Of course all provided as the usual UPM provider and others.
This includes:
11.0.110.0.210.0.19.0.1(CANCELLED UNTIL REQUESTED)8.0.3(CANCELLED UNTIL REQUESTED)8.0.28.0.1Edit: Will not backport 8.0.1 nor 8.0.2 in favor of instead only supporting 8.0.3, as they are only minor patches of the same version, and are fully backwards compatible. Same goes for 10.0.1, 10.0.2, and 11.0.1.
Edit 2: Will not do 9.0.x nor 8.0.x at all. See comments.
Why we need this
To gain more users. More users equals more bug reports. More bug reports equals more bugfixes. More bugfixes equals better repository.
Suggested solution
For each old version, create a new release, and revert the changes made from for example 11.0.2 to 12.0.1. Important to keep track of the conflicting changes.
Deployment can perhaps be automated with making a
backport
branch with deployment jobs of the CI/CD enabled. Or just doing it manually.The text was updated successfully, but these errors were encountered: