[Function builders] Fix-Its and code completion improvements #33972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a use of a function builder involves a statement kind that the function builder doesn't support (e.g., if-else), add a note to the diagnostic that specifies what methods need to be added to the function builder to support that statement, including Fix-Its with stub implementations.
When performing code completion inside the declaration of a type with the function builder attribute, also include completions for all of the possible "build" functions.
beccadax
reviewed
Sep 16, 2020
Add brief documentation comments to each of the code completions produced for a build* function in a code completion.
theblixguy
reviewed
Sep 16, 2020
theblixguy
reviewed
Sep 16, 2020
rintaro
reviewed
Sep 16, 2020
Introduce an educational note with a synopsis of the build* function declarations one can add to a function builder, and associate it with the diagnostics indicating incorrect or missing build* functions.
…esults. Noticed by Rintaro, thank you!
…Availability The lack of these functions in a function builder is diagnosed in different places in the type checker. Extend these diagnostics to provide stubs in the function builder. Thanks to Suyash for the suggestion!
|
@swift-ci smoke test |
|
Fix-It matching with newlines doesn't work with Windows because of CRLF. Sigh. |
Testing newlines in Fix-Its does not work well with Windows, so separate out the Fix-It tests for function builder stubs.
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test macOS |
1 similar comment
|
@swift-ci please smoke test macOS |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend diagnostics and code completion to help guide developers toward implementing function builders. Specifically:
buildmethod, e.g., because the body usesif-elsebut the function builder doesn't providebuildEither(first:)andbuildEither(second:), add a note + Fix-It to the error message that adds stubs for the functions needed to support those statements.buildfunctions that function builders support.Fixes SR-13536 / rdar://problem/68732123