[stdlib] using static method dispatch instead of failable casts #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gribozavr please have a look. |
| } | ||
|
|
||
|
|
||
| } |
moiseev
force-pushed
the
no-failable-cast
branch
from
e6ae147 to
4b705a0
Compare
|
Updated. |
| S.SubSequence : SequenceType, | ||
| S.SubSequence.Generator.Element == Element, | ||
| S.SubSequence.SubSequence == S.SubSequence | ||
| >(_ base: S) { |
There was a problem hiding this comment.
This changes the signature. We want to constrain SequenceType.SubSequence this way anyway, but don't have the necessary language feature. Nevertheless, this requires a writing a proposal in swift-evolution.
|
The change LGTM, but because of the signature change in |
gribozavr
added
the
swift evolution pending discussion
|
Will do. Thanks for reviewing it. |
Overriding `AnySequence.dropFirst` and `AnySequence.prefix` to delegate these operations to an underlying sequence, thus simplifying default implementations in `Sequence`.
moiseev
force-pushed
the
no-failable-cast
branch
from
4b705a0 to
d225b37
Compare
|
Rebased and ready to go. |
moiseev
added
swift evolution approved
|
Needs splitting. |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
…ext_for_key Temporarily move dispatch_context_for_key test into the unreliable tests
dabelknap
added a commit
to dabelknap/swift
that referenced
this pull request
Feb 13, 2019
Demote ColonWhitespace to a lint rule
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
[NFC] Fix 'Traling' typo
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Add SwiftyStoreKit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding
AnySequence.dropFirstandAnySequence.prefixto delegatethese operations to an underlying sequence, thus simplifying default
implementations in
Sequence.