[stdlib] Make standard library index types Hashable #12777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecook1000
added
the
swift evolution pending discussion
natecook1000
removed
the
swift evolution pending discussion
natecook1000
force-pushed
the
nc-index-hashable
branch
from
adc1dd2 to
8245d97
Compare
|
@swift-ci Please smoke test |
natecook1000
changed the title
|
This fully implements SE-0188, including conditional conformance of wrapping types, now that it has been approved. |
|
This looks great. Could you add a ChangeLog entry and merge? |
This adds Hashable conformance for the String, Dictionary, and Set's index types.
natecook1000
force-pushed
the
nc-index-hashable
branch
from
7564d53 to
f7c55d2
Compare
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Hashableconformance for theString,Dictionary, andSetindex types.Proposal here: swiftlang/swift-evolution#761