[SR-7338] Handle cookies in URLSession #1542
Conversation
mamabusi
changed the title
|
@swift-ci please test |
|
@ianpartridge Could you please review this PR. |
| let r = request.createMutableURLRequest() | ||
| _configuration.configure(request: r) | ||
| var r = request.createMutableURLRequest() | ||
| r = _configuration.configure(request: r) |
There was a problem hiding this comment.
Why not just return _configuration.configure(request: r)?
| var request = request | ||
| httpAdditionalHeaders?.forEach { | ||
| guard request.value(forHTTPHeaderField: $0.0) == nil else { return } | ||
| request.setValue($0.1, forHTTPHeaderField: $0.0) | ||
| } | ||
| request = setCookies(on: request) |
There was a problem hiding this comment.
return setCookies(on: request)?
| if httpShouldSetCookies { | ||
| //TODO: Ask the cookie storage what cookie to set. | ||
| if let cookieStorage = self.httpCookieStorage, let cookies = cookieStorage.cookies(for: request.url!) { |
There was a problem hiding this comment.
Please remove the force unwrap, e.g.
if let cookieStorage = self.httpCookieStorage,
let url = request.url,
let cookies = cookieStorage.cookies(for: url) {
...
}
mamabusi
force-pushed
the
urlSessionCookies-branch
branch
from
e9201e1 to
41c914a
Compare
|
@ianpartridge Thanks for the suggestions. I have made the necessary changes and updated the branch. |
|
@swift-ci please test |
|
@spevans @mamabusi @ianpartridge Would it be possible to get this merged into 4.2 branch? I think this is an important piece of functionality that's missing from Swift 4.2 release. Also, looks like this was partially already merged in via this PR: I think it was by accident? The new test cases made it to Swift 4.2 branch, but not the actual code... |
|
@maksimorlovich Sure, I'll be creating a PR soon for the Swift 4.2 branch. |
This PR implements storage of HTTP cookies received as part of the response from the server and setting of appropriate cookies on the URLRequest of the URLSession.