Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the set of cross-compilation arguments with SwiftPM #601

Closed
stevapple opened this issue Aug 1, 2022 · 6 comments
Closed

Align the set of cross-compilation arguments with SwiftPM #601

stevapple opened this issue Aug 1, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@stevapple
Copy link
Contributor

SourceKit-LSP is missing most of the dedicated arguments for cross-compilation that was introduced in SwiftPM, which makes it hard to use when it comes to cross-compiling.

Ideally it should gain the same level of support with swift build. The missing ones are:

  • --destination <destination>
  • --triple <triple>
  • --sdk <sdk>
  • --toolchain <toolchain>
@stevapple
Copy link
Contributor Author

Note that there was an attempt for --destination at #330, but it was suspended.

@stevapple
Copy link
Contributor Author

It would be better if destination.json can be hot-reloaded so the IDE can have direct control on the settings.

@ahoppen
Copy link
Member

ahoppen commented Aug 2, 2022

rdar://97961537

@ahoppen ahoppen added the bug Something isn't working label Aug 22, 2022
@filip-sakel
Copy link

Hello! Sorry for resurrecting this, but SwiftWasm is currently quite limited on VS Code because of this issue. Was there something intrinsically wrong with #330 or was there just a problem with tests failing? I'm wondering how I could get started (if I need to be aware of any challenges, any useful pointers) to hopefully fix this issue.

@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented May 18, 2023

I've left a comment on that PR, but I also think we need an additional LSP message type to allow client extensions to switch between available Swift SDKs, not just triples. That probably also implies querying for a list of already installed SDKs so that a user is able to select one from the list.

@MaxDesiatov
Copy link
Contributor

Closing as a duplicate of #786.

@MaxDesiatov MaxDesiatov closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants