Migrate to use AsyncHTTPClient #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xTim This seems to have a merge conflict with your other PR I merged a few days ago |
alexanderjordanbaker
added a commit
to alexanderjordanbaker/app-store-server-library-swift
that referenced
this pull request
Nov 16, 2023
|
@alexanderjordanbaker resolved! |
alexanderjordanbaker
added a commit
to alexanderjordanbaker/app-store-server-library-swift
that referenced
this pull request
Nov 16, 2023
|
Hey @0xTim as you saw I'm messing around with the errors found in your build, do you have any ideas on those? I didn't get them building locally |
|
@alexanderjordanbaker SwiftPM issue, think the latest build should fix it |
| let response = try await httpClient.execute(urlRequest, timeout: .seconds(30)) | ||
| var body = try await response.body.collect(upTo: 1024 * 1024) | ||
| guard let data = body.readData(length: body.readableBytes) else { | ||
| return .nonTerminalError(OCSPFetchError()) |
There was a problem hiding this comment.
Why is this not a terminalError? If we are unable to read data from the OCSP response, wouldn't that be an unrecoverable error?
There was a problem hiding this comment.
Err I seem to remember it being caught elsewhere but yeah you're right. I'll update
alexanderjordanbaker
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLSession is broken, incomplete and generally just a mess on Linux. For server-side applications to recommendation is to use AsyncHTTPClient. This PR migrates from
URLSessionto use AsyncHTTPClient instead.Resolves #4