-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: LocationManager provider #174
Conversation
Dor-bl
commented
May 18, 2024
- Updated createLocationManagerMockProvider method to use getProviderProperties for API level 31 and above.
- Added runtime API level checks to ensure backward compatibility with API levels below 31.
- Removed dependency on LocationProvider in the calling method.
- Handled null cases for provider name and provider properties.
- Ensured compatibility and adherence to modern Android best practices.
- Updated createLocationManagerMockProvider method to use getProviderProperties for API level 31 and above. - Added runtime API level checks to ensure backward compatibility with API levels below 31. - Removed dependency on LocationProvider in the calling method. - Handled null cases for provider name and provider properties. - Ensured compatibility and adherence to modern Android best practices.
@mykola-mokhnach , I see the install dependencies failed. |
For the lint error, it can have |
Add SuppressLint Error Add Javadoc
It looks like https://developer.android.com/about/versions/12/non-sdk-12 It looks like the animation command usage is only for lower than API level 26 https://github.com/appium/appium-uiautomator2-driver/blob/4cd489aa9a282f412ee45e1366c86bf7e580c798/lib/driver.ts#L594-L597 We could add an annotation for |
lg, but please wait for appium/appium-espresso-driver#1007 so that we can safely apply the animation related change for lower os versions only |
🎉 This PR is included in version 5.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |