feat: launch WDA via devicectl object #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: calls launch app process command with devicectl via this.device.devicectl
| this.log.debug(`The output of devicectl command: ${stdout}`); | ||
| await this.device.devicectl.launchApp({ | ||
| bundleId: this.bundleIdForXctest, env, terminateExisting: true, | ||
| }); |
There was a problem hiding this comment.
In the error message below:
The 'appium:wdaLaunchTimeout' capability ....
mykola-mokhnach
approved these changes
Mar 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
## [8.0.0](v7.3.1...v8.0.0) (2024-03-25) ### ⚠ BREAKING CHANGES * calls launch app process command with devicectl via this.device.devicectl ### Features * launch WDA via devicectl object ([#870](#870)) ([090b815](090b815))
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: calls launch app process command with devicectl via this.device.devicectl.
This change will require appium/appium-xcuitest-driver#2354.
After merging this, this lib will bump the major version. Then the xcuitest driver should bump the wda deps with the expected major version.