fix: respect defaultActiveApplication in activeApplication selection #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
KazuCocoa
changed the title
KazuCocoa
changed the title
mykola-mokhnach
approved these changes
Mar 13, 2024
mykola-mokhnach
approved these changes
Mar 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
## [7.1.1](v7.1.0...v7.1.1) (2024-03-13) ### Bug Fixes * respect defaultActiveApplication in activeApplication selection ([#862](#862)) ([b1ddae2](b1ddae2))
|
🎉 This PR is included in version 7.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered if we could follow
defaultActiveApplicationfirst if it was not auto, which means the session explicitly wants to interact with the defaultActiveApplication first.Then,
driver.settings.update({defaultActiveApplication: 'com.apple.springboard'})would help to interact with springboard elements in a session like keyboard as well. It is easy to move to the default behavior withdriver.settings.update({defaultActiveApplication: 'auto'})Maybe.. current implementation no longer work with defaultActiveApplication unless a session does not include bundleId/app