-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update keyboard typing implementation #832
Conversation
@Dan-Maor I believe we may also bump the default value of typing frequency, which currently equals to 60. |
Will take a look tomorrow or the next (just a note) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will investigate regarding XCTest’s default value on Sunday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg. I have tested on a tvOS device as well, which has no focus.
+ (NSUInteger)defaultTypingFrequency | ||
{ | ||
NSInteger defaultFreq = [[NSUserDefaults standardUserDefaults] | ||
integerForKey:@"com.apple.xctest.iOSMaximumTypingFrequency"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
## [5.15.6](v5.15.5...v5.15.6) (2024-01-06) ### Miscellaneous Chores * Update keyboard typing implementation ([#832](#832)) ([06cfb3b](06cfb3b))
🎉 This PR is included in version 5.15.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Apple did major changes to the typing implementation since Xcode 13