fix: set appearance in iOS 17+ #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Dec 7, 2023
| // Xcode 14.3.1 can build these values. | ||
| // For iOS 17+ | ||
| if ([self respondsToSelector:NSSelectorFromString(@"appearance")]) { | ||
| self.appearance = (XCUIDeviceAppearance) appearance; |
There was a problem hiding this comment.
I assume it would still be logical to read this value in the getter instead of the appearanceMode mode one in the getter
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
## [5.15.4](v5.15.3...v5.15.4) (2023-12-07) ### Bug Fixes * set appearance in iOS 17+ ([#818](#818)) ([357a2cb](357a2cb))
|
🎉 This PR is included in version 5.15.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like iOS 17 needs to set appearance via below API.
In my testing, iOS 16.7 worked with
setAppearanceModeso it would be safe to checksetAppearanceModefirst, thenappearance