Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make isFocused attribute available for iOS elements #692

Merged
merged 2 commits into from
May 4, 2023
Merged

feat: Make isFocused attribute available for iOS elements #692

merged 2 commits into from
May 4, 2023

Conversation

mykola-mokhnach
Copy link

@mykola-mokhnach mykola-mokhnach requested a review from KazuCocoa May 2, 2023 19:51
KazuCocoa
KazuCocoa approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

minor: Will you include for xpath as well?
https://github.com/appium/WebDriverAgent/blob/master/WebDriverAgentLib/Utilities/FBXPath.m#L98-L104

@KazuCocoa
Copy link
Member

Btw, I think we also can expose isSelected and hasKeyboardFocus for the page source and attribute. let me create this idea

@mykola-mokhnach
Copy link
Author

mykola-mokhnach commented May 2, 2023 •
edited
Loading

lg

minor: Will you include for xpath as well? https://github.com/appium/WebDriverAgent/blob/master/WebDriverAgentLib/Utilities/FBXPath.m#L98-L104

not sure we need to overload page source xml with this stuff
this attribute makes sense for a very limited set of elements

@KazuCocoa
Copy link
Member

KazuCocoa commented May 2, 2023 •
edited
Loading

Sounds good. not have a strong motivation for the XPath things.

(not for this pr)
Btw, what I could remember about this focus in non tvOS env, I could not find cases the return value became true in the past. Probably.... bluetooth keyboard or something accessibility functionality is needed for ios...? (i don't know well)

I wondered if the original motivation to expose the focused was expected by hasKeyboardFocus's result. I mean if an element was focused by keyboard like a search bar.

@KazuCocoa
Copy link
Member

btw, should we merge this for appium/appium-xcuitest-driver#1661 ...? let me merge this

@KazuCocoa KazuCocoa merged commit 0ec74ce into master May 4, 2023
@KazuCocoa KazuCocoa deleted the focus branch May 4, 2023 20:10
github-actions bot pushed a commit that referenced this pull request May 4, 2023
@semantic-release-bot
chore(release): 4.15.0 [skip ci]
2ec5a4b 
## [4.15.0](v4.14.0...v4.15.0) (2023-05-04)

### Features

* Make isFocused attribute available for iOS elements ([#692](#692)) ([0ec74ce](0ec74ce))
@github-actions
Copy link

github-actions bot commented May 4, 2023

🎉 This PR is included in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@KazuCocoa KazuCocoa mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mykola-mokhnach @KazuCocoa