Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis tests previous amplifier #489

Closed
generalhenry opened this issue Nov 22, 2016 · 2 comments · Fixed by #491
Closed

Travis tests previous amplifier #489

generalhenry opened this issue Nov 22, 2016 · 2 comments · Fixed by #491

Comments

@generalhenry
Copy link
Contributor

Currently my build is failing on travis: https://travis-ci.org/appcelerator/amp/builds/178074710

This is due to a initialization bug introduced by #479

I'm working on a fix to the initialization bug, but the issue will still remain that amp pf pull && amp pf start pulls and starts amplifier from docker hub.

@generalhenry
Copy link
Contributor Author

generalhenry commented Nov 22, 2016

@bquenin I fixed the init bug and hot pushed to docker hub to work around the prev build issue. I see your work in https://github.com/appcelerator/amp/tree/amp-tests-fix which looks like you're making headway.

My current thinking is:
./shrink local
amp platform pull --local
amp platform start --local
Which would build the amp image locally, skip pulling amp and then launch services with the local amp image.

@bquenin
Copy link
Contributor

bquenin commented Nov 22, 2016

You're right, I was working on a fix, but yours is better.
I'll submit a pull request with a doc for local test development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants