Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages when plugin is not found #120

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Better error messages when plugin is not found #120

merged 1 commit into from
Mar 2, 2016

Conversation

zachgersh
Copy link
Contributor

Depends on #121


Previously when the plugin failed to be found the error message would be unhelpful:

mynet : error executing ADD: could not find "." plugin

Now, error message looks like

mynet : error executing ADD: failed to find plugin "some-plugin" in path [/gopath/src/github.com/appc/cni/bin]
  • Added tests in the ginkgo style (which means ginkgo / gomega are godep'ed)
  • Tests are now run as part of the testing script
  • Testing style of /pkg/invoke is now much more descriptive + covers edge cases
  • ginkgo / gomega style tests still work with the regular old go test command

@zachgersh zachgersh mentioned this pull request Feb 11, 2016
@steveej
Copy link
Member

steveej commented Feb 12, 2016

Thanks @zachgersh for these test cases. This work is highly appreciated!

Please make the addition of ginkgo / gomega deps a separate commit preceding all commits that make use of the new packages.

@zachgersh
Copy link
Contributor Author

Thanks @steveej! I am actually going to pull ginkgo / gomega out of this PR. If you would be so kind as to merge #121 first then those dependencies will be added and these tests should just work!

Really appreciate the quick feedback.

@zachgersh
Copy link
Contributor Author

@steveej this commit is now ready. I will add the tests being run back in once both the PRs I have outstanding have been merged 👯

steveej added a commit that referenced this pull request Mar 2, 2016
Better error messages when plugin is not found
@steveej steveej merged commit c44bc01 into containernetworking:master Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants