Skip to content

Commit

Permalink
fix(dropdown): add missing multi-select placeholder (#505)
Browse files Browse the repository at this point in the history
  • Loading branch information
Igor Milly authored and GitHub Enterprise committed Jan 31, 2022
1 parent 0dff959 commit c64da50
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<div nxCol="12, 12, 6">
<nx-formfield nxLabel="Fruits">
<nx-multi-select
placeholder="Choose options"
[options]="complexOptions"
[selectLabel]="selectLabel"
[selectValue]="selectValue"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ <h3>With filter</h3>
<nx-formfield appearance="outline" nxFloatLabel="always" nxLabel="Multi select">
<nx-multi-select
filter
placeholder="Choose options"
[(ngModel)]="modelWithFilter"
[options]="options"
selectValue="id"
Expand All @@ -17,6 +18,7 @@ <h3>With filter</h3>
<h3>Without filter</h3>
<nx-formfield appearance="outline" nxFloatLabel="always" nxLabel="Multi select">
<nx-multi-select
placeholder="Choose options"
[(ngModel)]="model"
[options]="options"
[selectLabel]="selectLabel"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
(focus)="_inputFocused = true"
(keydown)="_onKeydown($event)"
>
<span class="value-text">{{ _getValueText() }}</span>
<span class="value-text">{{ empty ? placeholder : _getValueText() }}</span>
<span>{{ selectedItems.size ? '(' + selectedItems.size + ')' : '' }}</span>
<nx-icon size="s" aria-hidden="true" class="indicator" name="chevron-down"></nx-icon>
</div>
Expand Down

0 comments on commit c64da50

Please sign in to comment.