Skip to content

Commit

Permalink
fix(accordion): correct paddings and add missing css variables (#415)
Browse files Browse the repository at this point in the history
* feat: retail regular desktop body paddings

* feat: padding progress

* feat: apply neww variables

* feat: expert paddings

* feat: misc changes

* feat: misc change

* feat: add header padding variable

Co-authored-by: Igor Milly <[email protected]>
  • Loading branch information
2 people authored and GitHub Enterprise committed Nov 29, 2021
1 parent bac8599 commit 0f7a231
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 7 deletions.
4 changes: 2 additions & 2 deletions projects/ng-aquila/src/accordion/expansion-panel-header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
@include var(background, accordion-regular-header-background-color);

@include media-breakpoint-down(small) {
padding: nx-spacer(s);
padding: v(accordion-regular-mobile-header-padding);
}
}

Expand Down Expand Up @@ -74,7 +74,7 @@ $header-title-small-screen-margin-after: nx-spacer(s);
background: transparent;

@include media-breakpoint-down(small) {
padding: nx-spacer(s) 0;
padding: v(accordion-light-mobile-header-padding);
}
}

Expand Down
4 changes: 2 additions & 2 deletions projects/ng-aquila/src/accordion/expansion-panel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
@include type-style(accordion-body);

@include media-breakpoint-down(small) {
padding: nx-spacer(m) nx-spacer(s);
padding: v(accordion-regular-mobile-body-padding);
}
}

Expand Down Expand Up @@ -70,7 +70,7 @@
padding: v(accordion-light-body-padding);

@include media-breakpoint-down(small) {
padding: 0 0 nx-spacer(m);
padding: v(accordion-light-mobile-body-padding);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ $expert-theme: (
accordion-light-hover-chevron-color: interactive-text,

accordion-light-header-padding: 16px,
accordion-light-mobile-header-padding: 16px 0,
accordion-light-body-padding: 0 16px 16px,
accordion-light-mobile-body-padding: 0 0 16px,

accordion-regular-header-background-color: ui-02,
accordion-regular-header-hover-text-color: interactive-text,
Expand All @@ -31,7 +33,9 @@ $expert-theme: (
accordion-regular-mobile-border-color: ui-04,
accordion-regular-mobile-separator-color: transparent,
accordion-regular-header-padding: 16px,
accordion-regular-mobile-header-padding: 16px,
accordion-regular-body-padding: 16px,
accordion-regular-mobile-body-padding: 16px,

comparison-table-placeholder-cell-border-color: comparison-table-border-color,
comparison-table-toggle-section-header-padding: 16px,
Expand Down
10 changes: 7 additions & 3 deletions projects/ng-aquila/src/shared-styles/theming/tokens.scss
Original file line number Diff line number Diff line change
Expand Up @@ -227,19 +227,23 @@ $nx-theme: (
accordion-regular-mobile-separator-color: ui-04,

accordion-regular-header-padding: 24px 32px,
accordion-regular-body-padding: 24px 32px,
accordion-regular-mobile-header-padding: 16px,
accordion-regular-body-padding: 24px 32px 16px,
accordion-regular-mobile-body-padding: 24px 16px 32px,
accordion-light-header-text-color: interactive-text,
accordion-light-header-hover-text-color: interactive-text,
accordion-light-chevron-color: interactive-text,
accordion-light-hover-chevron-color: interactive-text,
accordion-light-header-padding: 24px 32px,
accordion-light-body-padding: 24px 32px,
accordion-light-mobile-header-padding: 16px 0,
accordion-light-body-padding: 0 32px 32px,
accordion-light-mobile-body-padding: 0 0 24px,
accordion-light-border-color: ui-04,

accordion-extra-light-header-top-margin: 16px,
accordion-extra-light-chevron-color: interactive-text,
accordion-extra-light-header-text-color: interactive-text,
accordion-extra-light-body-padding: 8px 0 8px 0,
accordion-extra-light-body-padding: 16px 0 8px,

accordion-extra-light-font-size: 16px,
accordion-extra-light-line-height: 24px,
Expand Down

0 comments on commit 0f7a231

Please sign in to comment.