Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

change default keep-alive setting from 10s to 30s #368

Merged
merged 5 commits into from
Mar 19, 2018

Conversation

huan
Copy link
Contributor

@huan huan commented Mar 7, 2018

following the graphcool server setting. See: #167

The problem described at https://www.graph.cool/forum/t/invoking-a-subscription-event-frequently-in-a-short-amount-of-time/1298/6?u=huan is not solved if the timeout is set to 10s.

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@mxstbr
Copy link
Contributor

mxstbr commented Mar 19, 2018

According to #167 the timeout was already increased to 30s, is that incorrect? If so we should definitely ship this!

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, this wasn't actually fixed! Thanks for the PR ❤️

@gijo-varghese
Copy link

I think there is a bug

link.subscriptionClient.maxConnectTimeGenerator.duration = () => link.subscriptionClient.maxConnectTimeGenerator.max

Above code fixed the issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants