Apollo hapi #46
Merged
Apollo hapi #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollo-hapi # Conflicts: # src/index.ts
…ollo-hapi # Conflicts: # src/integrations/integrations.test.ts
|
@nnance Is this basically ready to be merged? |
| } else { | ||
| const gqlResponse = responses[0]; | ||
| if (gqlResponse.errors && typeof gqlResponse.data === 'undefined') { | ||
| reply(gqlResponse).code(400); |
There was a problem hiding this comment.
I'm starting to wonder whether we should have gotten rid of HTTP error codes altogether. What do you think?
|
This looks great, can't wait to use it! |
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@helfer this PR is ready for review. All the integration tests now pass for HAPI and Express. I have asked @wookiehangover to help with the HAPI review.