Support subclassing Observable with non-class constructor functions. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
commented
Feb 2, 2021
| function construct(Super, instance, subscriber) { | ||
| return typeof Reflect === 'object' | ||
| ? Reflect.construct(Super, [subscriber], instance.constructor) | ||
| : Function.prototype.call.call(Super, instance, subscriber) || instance; |
There was a problem hiding this comment.
We have to use Function.prototype.call.call(Super, ...) instead of Super.call(...), since Super is often the Observable constructor, and we do not want to call back into the Observable.call implementation above.
benjamn
force-pushed
the
allow-non-native-subclassing
branch
from
7895e15
to
26e8623
Compare
benjamn
force-pushed
the
allow-non-native-subclassing
branch
from
26e8623
to
304255e
Compare
benjamn
added a commit
that referenced
this pull request
Aug 24, 2021
We implemented these methods explicitly in PR #1, but then PR #105 went back to compiling `Observable` down to ES5 constructor functions. In other words, the current implementations of `Observable` (both CommonJS and ESM) automatically have these static methods, and they work just like `Function.prototype.{call,apply}`, because `Observable` is compiled in both cases from a `class` to a constructor function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apollographql/apollo-client#7640 (comment)