bug: crashed due to problems with system's resolv.conf

[seanahrens]

I ran curl -sSL https://rover.apollo.dev/nix/latest | sh

Then got
downloading rover from https://github.com/apollographql/rover/releases/download/v0.10.0/rover-v0.10.0-aarch64-apple-darwin.tar.gz
Houston, we have a problem. Rover crashed!
To help us diagnose the problem you can send us a crash report.

Description

Describe the issue that you're seeing.

Crash Report

name = 'rover'
operating_system = 'unix:OSX'
crate_version = '0.10.0'
explanation = '''
Panic occurred in file 'src/utils/telemetry.rs' at line 121
'''
cause = '''
could not get request client: RoverError { error: builder error: error reading DNS system conf: Error parsing resolv.conf: ProtoError { kind: Msg("Malformed label: http://google") }

Caused by:
    error reading DNS system conf: Error parsing resolv.conf: ProtoError { kind: Msg("Malformed label: http://google") }, metadata: RoverErrorMetadata { suggestion: None, code: None, skip_printing_cause: false, json_version: One } }'''
method = 'Panic'
backtrace = '''

   0: 0x102c88f28 - core::panicking::panic_fmt::ha46aa9af97eb193d
   1: 0x102c89014 - core::result::unwrap_failed::h730969f28291ae99
   2: 0x102573d08 - sputnik::session::Session::new::h4b17d8099e7a37f4
   3: 0x1025f2a3c - rover::cli::Rover::run::ha84ff179142ac372
   4: 0x1025f28d4 - rover::cli::Rover::run_from_args::h9349f3fb60992fc4
   5: 0x102526290 - rover::main::h3312d0661a7ca085
   6: 0x1025267dc - std::sys_common::backtrace::__rust_begin_short_backtrace::h099b4e10ce697fc8
   7: 0x10252679c - std::rt::lang_start::{{closure}}::he83da166246fad48
   8: 0x102c33164 - std::rt::lang_start_internal::h94fa211da9d06d56
   9: 0x102526558 - _main'''

[EverlastingBugstopper]

Hi @seanahrens it looks like there is a problem with your system's DNS file which is located at /etc/resolv.conf. specifically it looks like there is a line that starts with http://google which is not a valid label. it's unfortunate that we panic here, but this library is deeply nested in our dependency tree (reqwest -> trust-dns-resolver -> resolv-conf. My suggestion is that you remove the invalid line from your DNS configuration and try again.

[seanahrens]

Thanks for describing that error to me. Upon inspecting my resolv.conf file, the only line I see that matches what you describe is "search http://google.com". I tried removing this line, but, upon a system restart, the line came back as before. I'm giving up here, since I'm not immediately trying to use rover this week, so if and when I come back to it, I might try to address the problem then. Thank you.

[EverlastingBugstopper]

It's interesting that it's formatted like that... I wonder why. Just looking at the tests for the resolv-conf crate, they have this example:

#
# Mac OS X Notice
#
# This file is not used by the host name and address resolution
# or the DNS query routing mechanisms used by most processes on
# this Mac OS X system.
#
# This file is automatically generated.
#
options ndots:8 timeout:8 attempts:8
domain example.com.
search example.com. sub.example.com.
nameserver 2001:4860:4860::8888
nameserver 2001:4860:4860::8844
nameserver 8.8.8.8
nameserver 8.8.4.4

as you can see, the search entries are like example.com. instead of http://google.com. I'm not sure exactly what process is overwriting this on your MacOS device on startup, but my guess is there's some "search engine" property in network settings that you could update to google.com instead of http://google.com? that's my hunch anyway.

[seanahrens]

Yeah I noticed that as well. I tried tracking down the setting or other file which is generating my resolv.conf. It looked like a potential rabbit hole, so I stopped there only to resume when I restart work on this project. Thank you!

[EverlastingBugstopper]

going to re-open this issue and link to it for other folks experiencing the same.