Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup output says "Listening on http://http://" #447

Closed
abernix opened this issue Feb 11, 2022 · 1 comment · Fixed by #448
Closed

Startup output says "Listening on http://http://" #447

abernix opened this issue Feb 11, 2022 · 1 comment · Fixed by #448
Assignees
@garypen
Labels
bug

Comments

@abernix
Copy link
Member

abernix commented Feb 11, 2022

Router from version built from bef4fc6 reveals an invalid URL on startup — http://http://127.0.0.1:4000:

2022-02-11T10:11:23.706072Z  INFO apollo_router::trace: spaceport: None, graph: None
2022-02-11T10:11:24.130394Z  INFO router: Listening on http://http://127.0.0.1:4000 🚀
@abernix abernix added the bug label Feb 11, 2022
@garypen
Copy link
Contributor

garypen commented Feb 11, 2022

I think this crept in with: #158

Removing the hard-coded "http://" from the startup message and also adding "file:" for Display for UDS seems a good approach for now.

@garypen garypen self-assigned this Feb 11, 2022
@garypen garypen mentioned this issue Feb 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Startup output says "Listening on http://http://" apollographql/router
2 participants
@garypen @abernix