Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support async topics #213

Closed
glentakahashi opened this issue Nov 25, 2019 · 3 comments · Fixed by #220
Closed

Support async topics #213

glentakahashi opened this issue Nov 25, 2019 · 3 comments · Fixed by #220

Comments

@glentakahashi
Copy link

It would be nice to support returning a promise of an AsyncIterator as the ResolverFn. This is also supported in graphql-js graphql/graphql-js#918

This would enable use cases like MichalLytek/type-graphql#470 where we could handle authorization at the topics/resolver level of a subscription, rather than within the filter.
@glentakahashi glentakahashi mentioned this issue Nov 25, 2019
Closed
@maclockard maclockard mentioned this issue Mar 25, 2020
Merged
@jan-wilhelm
Copy link

this is definitely needed. Why is this package no longer maintained?

@noxz-dev
Copy link

any news ?

@hwillson
Copy link
Member

#220 was merged and will be coming in release 3.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow resolver fn to be async maclockard/graphql-subscriptions
4 participants
@hwillson @glentakahashi @jan-wilhelm @noxz-dev