Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubSub.asyncIterator() return type #192

Open
stephentuso opened this issue Mar 4, 2019 · 5 comments · Fixed by #232
Open

pubSub.asyncIterator() return type #192

stephentuso opened this issue Mar 4, 2019 · 5 comments · Fixed by #232
Labels
enhancement good first issue Issues that are suitable for first-time contributors.

Comments

@stephentuso
Copy link

Shouldn't the return type be AsyncIterableIterator (TS lib file) instead of AsyncIterator? I see it has the Symbol.asyncIterator property here
@grantwwu
Copy link
Contributor

grantwwu commented Mar 4, 2019 •
edited
Loading

Sounds correct - would you like to make a PR?

@grantwwu grantwwu added enhancement good first issue Issues that are suitable for first-time contributors. labels Mar 4, 2019
@stephentuso
Copy link
Author

Will do 👍

@stephentuso stephentuso mentioned this issue Mar 10, 2019
Closed
@ghost
Copy link

ghost commented Nov 13, 2019

Hmm if we use just AsyncIterator<T> how can we check the types of return object? Should we use AsyncIterator<T, TReturn, TNext> instead?

@hyochan
Copy link

hyochan commented Jan 18, 2020 •
edited
Loading

Any news on this? How I should I have to type below case?

image

@n1ru4l n1ru4l mentioned this issue Sep 21, 2020
Merged
@glasser glasser mentioned this issue Feb 25, 2022
Closed
@maxpain
Copy link

maxpain commented Jun 20, 2022

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
4 participants
@grantwwu @maxpain @stephentuso @hyochan