Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[email protected]] APQ registration causes "addProtobufError called before startTiming!" #3978

Closed
vanwalj opened this issue Apr 13, 2020 · 6 comments
Assignees
Labels
🪲 bug 🥀 needs-reproduction Lacks a runnable reproduction which can be used to quickly demonstrate a bug.

Comments

@vanwalj
Copy link

vanwalj commented Apr 13, 2020

I'm using apollo-server-lambda to serve a GraphQL Application in an AWS Lambda and apollo-client with apollo-link-persisted-queries so I can benefit from "persisted queries" feature

Upgrading to 2.12.0 broke the persisted queries requests, the server is now returning a 500 error whenever a client make a request using the persisted query extension

Here is a query exemple

{"operationName":"Themes","variables":{},"extensions":{"persistedQuery":{"version":1,"sha256Hash":"abc5e6f7d2b18d51853698b172c002b7866af0cab36178a6867b8f0f92a61a60"}}}

And here is the server response

{"errors":[{"message":"[internal apollo-server error] addProtobufError called before startTiming!","extensions":{"code":"INTERNAL_SERVER_ERROR"}}]}

Rollbacking apollo-server-lambda to 2.11.0 fixed the issue

@trevor-scheer
Copy link
Member

Thanks for the report @vanwalj. Can you please provide a reproduction? We'll start looking into this today but anything helps.

@abernix abernix changed the title Persisted queries are not working anymore since 2.12.0 [[email protected]] APQ registration causes "addProtobufError called before startTiming!" Apr 14, 2020
@abernix abernix added 🪲 bug 🥀 needs-reproduction Lacks a runnable reproduction which can be used to quickly demonstrate a bug. labels Apr 14, 2020
@abernix abernix self-assigned this Apr 14, 2020
@abernix abernix added this to the Release 2.12.1 milestone Apr 14, 2020
@abernix
Copy link
Member

abernix commented Apr 14, 2020

Seems related to #3627, which recently seems to have resurfaced #3627 (comment) and was still present in 2.11.0.

@abernix
Copy link
Member

abernix commented Apr 14, 2020

Looking into this now!

@abernix abernix pinned this issue Apr 14, 2020
@abernix
Copy link
Member

abernix commented Apr 14, 2020

I tried to reproduce this, deploying all the way to Lambda using serverless (the precise instructions are in our documentation, the only change I made was providing an ENGINE_API_KEY within the environment: property of provider within the serverless.yml).

However, I was unable to re-create this using [email protected] with Apollo Graph Manager enabled.

To move forward, we'll need much more precise reproduction steps (e.g. is this via POST, GET, directly invoked Lambda payload?, and as many details as you can provide!), as nothing would seem to have changed in the 2.12.0 release that would triangulate to the manifestation you're seeing here.

@vanwalj
Copy link
Author

vanwalj commented Apr 14, 2020

Thank you @trevor-scheer and @abernix for your investigations, I will try this week to isolate the problem on my side so we can reproduce it, I'll keep you updated!

Thanks again!

@abernix abernix unpinned this issue May 4, 2020
@abernix
Copy link
Member

abernix commented May 4, 2020

Happy to re-open this if you're able to provide a reproduction, but I'm going to close it for now.

@abernix abernix closed this as completed May 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug 🥀 needs-reproduction Lacks a runnable reproduction which can be used to quickly demonstrate a bug.
Projects
None yet
Development

No branches or pull requests

3 participants