Make possible run loggers and other middleware after graphqlExpress();

[pks1989]

Hello all!

I use graphqlExpress() in my project to send graphQL queries, and its work fine:

...

server.use(
    '/graphql',
    bodyParser.json(),
    graphqlUploadExpress({ maxFileSize: 10000000, maxFiles: 10 }),
    cors(),
    graphqlExpress(async request => ({
      schema,
      context: { headers: request ? request.headers : null },
    })),
  );

...

after some time I want to add the story of queries in my project so I try to do something like this:

...
server.use(
    '/graphql',
    bodyParser.json(),
    graphqlUploadExpress({ maxFileSize: 10000000, maxFiles: 10 }),
    cors(),
    graphqlExpress(async request => ({
      schema,
      context: { headers: request ? request.headers : null },
    })),
    logger((tokens, req, res) => {
      // parse res.body stuff and logging
    })
  );
...

and it's not working, I going to graphqlExpress() code and see that part:

...
 if (typeof res.send === 'function') {
    res.send(graphqlResponse);
  }
...

with no next() after send.

if i add next(), after send() my middleware code works fine:

if (typeof res.send === 'function') {
  res.send(graphqlResponse);
  next();
}

Sorry, if this dumb question, but why reason don't add next() after send() ?

[abernix]

Are you sure this is still problematic after the landing of #2842 in v2.8.0?

If not this will likely not be fixed until 3.x via #3184.

[glasser]

This is essentially a duplicate of #5560.