Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe: Rename PossiblyDeferred type #3144

Open
Tracked by #3093
calvincestari opened this issue Jul 24, 2023 · 0 comments
Open
Tracked by #3093

Maybe: Rename PossiblyDeferred type #3144

calvincestari opened this issue Jul 24, 2023 · 0 comments

Comments

@calvincestari
Copy link
Member

calvincestari commented Jul 24, 2023

This work is not required for delivery of the feature but is a quality of life improvement to the code with the introduction of @defer - RFC section link.

Adding support for @defer brings new meaning of the word 'deferred' to the codebase. There is an enum type named PossiblyDeferred which would cause confusion when trying to understand it’s intent. This type and its related functions should be renamed to disambiguate it from the incoming @defer related types and functions.

PossiblyDeferred is an internal type so this should have no adverse effect to users’ code.

@calvincestari calvincestari changed the title Rename PossiblyDeferred type - [RFC link](https://github.com/apollographql/apollo-ios/blob/spike/defer/Design/3093-graphql-defer.md#rename-possiblydeferred-typesfunctions) Rename PossiblyDeferred type Jul 24, 2023
@calvincestari calvincestari added this to the `@defer` support milestone Jul 24, 2023
@calvincestari calvincestari changed the title Rename PossiblyDeferred type Maybe: Rename PossiblyDeferred type Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants