Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Generate Sendable models #2884

Closed
tareksabry1337 opened this issue Mar 19, 2023 · 1 comment
Closed

Automatically Generate Sendable models #2884

tareksabry1337 opened this issue Mar 19, 2023 · 1 comment
Labels
feature New addition or enhancement to existing solutions

Comments

@tareksabry1337
Copy link

Use case

Currently we are adopting modern concurrency within our application and we are making use of Apollo extensively, However the generated objects are not Sendable which makes it hard to adopt modern concurrency without depending heavily on @unchecked Sendable which is sub-optimal and might lead to crashes eventually if the objects are mutated across different threads

Describe the solution you'd like

Introduce a flag for the auto generation script to get rid of the setters in the generated APIs and conform to Sendable for these models

@tareksabry1337 tareksabry1337 added the feature New addition or enhancement to existing solutions label Mar 19, 2023
@AnthonyMDev
Copy link
Contributor

Thank you for the feedback! This is already being tracked in #2835! We plan to look into this soon. As we know this is causing problems for users adopting Swift concurrency features.

@AnthonyMDev AnthonyMDev closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition or enhancement to existing solutions
Projects
None yet
Development

No branches or pull requests

2 participants