Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark library as side-effect free for TreeShaking improvements #3356

Closed
intellix opened this issue Apr 22, 2018 · 0 comments
Closed

Mark library as side-effect free for TreeShaking improvements #3356

intellix opened this issue Apr 22, 2018 · 0 comments

Comments

@intellix
Copy link
Contributor

intellix commented Apr 22, 2018

Webpack 4 added the ability to mark modules as being side-effect free. I'm not 100% sure but if this library isn't, we can mark individual files as having them. This was recently added to graphql-js as well :graphql/graphql-js#1312

Webpack docs: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

@ghost ghost added the feature label Apr 22, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant