Merge pull request #173 from apollostack/empty-error-array

Fix #156 by accepting non-spec-compliant empty error array

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 Expect active development and potentially significant breaking changes in the `0.x` track. We'll try to be diligent about releasing a `1.0` version in a timely fashion (ideally within 1 or 2 months), so that we can take advantage of SemVer to signify breaking changes from that point on.
 
+### vNEXT
+
+- Made client more robust in the case where the server returns an empty error array, even though that's not in the GraphQL spec. [Issue #156](https://github.com/apollostack/apollo-client/issues/155) [PR #173](https://github.com/apollostack/apollo-client/pull/173)
+
 ### v0.3.0
 
 - **Breaking change:** Require all queries to be wrapped with a `gql` template literal tag, and throw an error when they aren't. [Issue #155](https://github.com/apollostack/apollo-client/issues/155) [PR #168](https://github.com/apollostack/apollo-client/pull/168)

src/data/resultUtils.ts

@@ -0,0 +1,7 @@
+import {
+  GraphQLResult,
+} from 'graphql';
+
+export function graphQLResultHasError(result: GraphQLResult) {
+  return result.errors && result.errors.length;
+}

src/data/store.ts

@@ -22,6 +22,10 @@ import {
   ApolloReducerConfig,
 } from '../store';
 
+import {
+  graphQLResultHasError,
+} from './resultUtils';
+
 export interface NormalizedCache {
   [dataId: string]: StoreObject;
 }
@@ -53,7 +57,7 @@ export function data(
     }
 
     // XXX handle partial result due to errors
-    if (!action.result.errors) {
+    if (! graphQLResultHasError(action.result)) {
       const queryStoreValue = queries[action.queryId];
 
       // XXX use immutablejs instead of cloning

src/queries/store.ts

@@ -7,6 +7,10 @@ import {
   isQueryStopAction,
 } from '../actions';
 
+import {
+  graphQLResultHasError,
+} from '../data/resultUtils';
+
 import {
   SelectionSet,
   GraphQLError,
@@ -74,7 +78,7 @@ export function queries(
     }
 
     const newState = assign({}, previousState) as QueryStore;
-    const resultHasGraphQLErrors = action.result.errors && action.result.errors.length;
+    const resultHasGraphQLErrors = graphQLResultHasError(action.result);
 
     newState[action.queryId] = assign({}, previousState[action.queryId], {
       loading: false,

test/QueryManager.ts

@@ -168,6 +168,102 @@ describe('QueryManager', () => {
     });
   });
 
+  it('handles GraphQL errors with data returned', (done) => {
+    const query = gql`
+      query people {
+        allPeople(first: 1) {
+          people {
+            name
+          }
+        }
+      }
+    `;
+
+    const networkInterface = mockNetworkInterface(
+      {
+        request: {query },
+        result: {
+          data: {
+            allPeople: {
+              people: {
+                name: 'Ada Lovelace',
+              },
+            },
+          },
+          errors: [
+            {
+              name: 'Name',
+              message: 'This is an error message.',
+            },
+          ],
+        },
+      }
+    );
+
+    const queryManager = new QueryManager({
+      networkInterface,
+      store: createApolloStore(),
+      reduxRootKey: 'apollo',
+    });
+
+    const handle = queryManager.watchQuery({
+      query,
+    });
+
+    handle.subscribe({
+      next(result) {
+        assert.equal(result.errors[0].message, 'This is an error message.');
+        done();
+      },
+    });
+  });
+
+  it('empty error array (handle non-spec-compliant server) #156', (done) => {
+    const query = gql`
+      query people {
+        allPeople(first: 1) {
+          people {
+            name
+          }
+        }
+      }
+    `;
+
+    const networkInterface = mockNetworkInterface(
+      {
+        request: {query },
+        result: {
+          data: {
+            allPeople: {
+              people: {
+                name: 'Ada Lovelace',
+              },
+            },
+          },
+          errors: [],
+        },
+      }
+    );
+
+    const queryManager = new QueryManager({
+      networkInterface,
+      store: createApolloStore(),
+      reduxRootKey: 'apollo',
+    });
+
+    const handle = queryManager.watchQuery({
+      query,
+    });
+
+    handle.subscribe({
+      next(result) {
+        assert.equal(result.data['allPeople'].people.name, 'Ada Lovelace');
+        assert.notProperty(result, 'errors');
+        done();
+      },
+    });
+  });
+
   it('handles network errors', (done) => {
     const query = gql`
       query people {