Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of the system permission management page retrieving non-existent users. #4802

Merged
merged 79 commits into from
Mar 17, 2023

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Mar 15, 2023

What's the purpose of this PR

This pr has two changes as follows.

  • Retrieve user information from the user service API using the user ID obtained from the user permission table to avoid displaying non-existent user IDs on the page.
  • Sort the retrieved user list to make the page display more user-friendly when there are a large number of users retrieved.

Trigger scenario description: We switched from the local user system to LDAP. When a user in LDAP is deleted, it is not deleted synchronously. It is expected that there should be no user ID that does not exist in the system. When I try to delete this user ID, the check for the existence of the deleted user is triggered, so this is very contradictory.

klboke and others added 30 commits May 16, 2019 11:07
@klboke klboke requested a review from nobodyiam March 15, 2023 11:57
@nobodyiam
Copy link
Member

Please also fix the unit test.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #4802 (15322aa) into master (c6dfe76) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4802      +/-   ##
============================================
- Coverage     47.29%   47.24%   -0.06%     
  Complexity     1660     1660              
============================================
  Files           346      346              
  Lines         10683    10684       +1     
  Branches       1063     1064       +1     
============================================
- Hits           5053     5048       -5     
- Misses         5322     5328       +6     
  Partials        308      308              
Impacted Files Coverage Δ
.../spi/defaultimpl/DefaultRolePermissionService.java 69.23% <100.00%> (+0.26%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit bb15bec into apolloconfig:master Mar 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
@klboke klboke deleted the fix branch March 21, 2023 03:50
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants