-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue of the system permission management page retrieving non-existent users. #4802
Conversation
# Conflicts: # README.md
… page retrieving non-existent users.
Please also fix the unit test. |
Codecov Report
@@ Coverage Diff @@
## master #4802 +/- ##
============================================
- Coverage 47.29% 47.24% -0.06%
Complexity 1660 1660
============================================
Files 346 346
Lines 10683 10684 +1
Branches 1063 1064 +1
============================================
- Hits 5053 5048 -5
- Misses 5322 5328 +6
Partials 308 308
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
This pr has two changes as follows.
Trigger scenario description: We switched from the local user system to LDAP. When a user in LDAP is deleted, it is not deleted synchronously. It is expected that there should be no user ID that does not exist in the system. When I try to delete this user ID, the check for the existence of the deleted user is triggered, so this is very contradictory.